-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some explanation to example #13
Comments
Yeah, this is a good list of things to document. It should be pretty self-explanatory so if someone wants to take a stab at it I'd be willing to review it. |
@ChrisRackauckas then could you ask other contributors if they'd like to help with this or invite them here? |
Yeah, maybe @kanav99 can help out. Or it can be a first task for one of the next GSoCs. |
I would love to see some great documentation that explains the whole control flow in OrdinaryDiffEq. Best way should be to let a new student explore the repository and log down things as he/she may observe and finally make a PR. In any case, I can give this issue a stab myself too. |
We should also mention SimpleDiffEq.jl somewhere too, that's where I understood the complete flow from. |
Yeah, next GSoC would be a good time. I usually leave around little things like this as teaching exercises. |
To help newcomers, it would be nice to have an explained and commented example of a new algorithm like the existing Self-contained example which has some design points that are worth explaining:
T1
andT2
functions in the cache constructor? What operation do they perform on a method's coefficients?alg_cache
do? What do its arguments mean? Why should it be called by hand?integrator
contain: what iskshortsize
? what is the relation betweenisfsal
andfsalfirst
/fsallast
?initialize!
? Is it supposed to "pre-fill" all the known data like IVs/BCs, or something else?I believe it would be nice to have even simpler examples like Euler/the implicit midpoint
for explicit/implicit methods because, AFAIK, implicit methods are inherited from
Newton
integratators. Will they require additional caches or functions?The text was updated successfully, but these errors were encountered: