-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify parameters in-place in sciml_train! #140
Comments
I am going the complete other direction in #139 and just renaming it |
I'm totally fine with this as well, but it should probably be highlighted in the docs that |
Yes, it does behave differently from Flux.train! in more than one way, another being after #139 the boolean in the callback. Another is the |
Went the route of #139 |
This is more of a suggestion rather than an issue.
I'd find it much more intuitive to have
sciml_train!
to modify the parameters in-place, which would be consistent withFlux.train!
's behavior.The text was updated successfully, but these errors were encountered: