Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow parameters to be unknowns in the initialization system #2928

Merged
merged 19 commits into from
Oct 10, 2024

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Aug 6, 2024

I can't dev OrdinaryDiffEq locally for some reason: it isn't able to find a version of OrdinaryDiffEqSDIRK (and others). However, running the tests with OrdinaryDiffEqTsit5 and OrdinaryDiffEqNonlinearSolve dev'd works.

Requires

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Sep 5, 2024

Note to self: test all of the namespacing edgecases handled here

  • scalar-array broadcast involving a Ref in the traced expression
  • Array-array broadcast resulting in an ArrayOp
  • non-Array AbstractArray of symbolics (e.g. range)
  • symbolic array indexed with an array of indices
  • non-symbolic arrays should not be namespaced and should be returned as-is (===)

@AayushSabharwal
Copy link
Member Author

Thank god, the rebase worked

@ChrisRackauckas ChrisRackauckas merged commit 385c034 into SciML:master Oct 10, 2024
19 of 25 checks passed
@AayushSabharwal AayushSabharwal deleted the as/param-init branch October 10, 2024 08:16
@hersle
Copy link
Contributor

hersle commented Oct 10, 2024

Thanks for all the hard work that went into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants