Vector ODE duplicating length of intial condition and not shifting equation to observed #2964
Labels
bug
Something isn't working
Comments
|
The only way I have made this work is to instead of creating and matching the variable 'y' instead you must send dY.y to the function rhs_wrapper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is 2 bugs that I think are somewhat interlinked. First of when I structural_simplify a model where I set a vector variable to equal 'itself' in a different namespace in a connection, structural_simplify doesn't shift this connection to observed and instead thinks that these are equations it needs to solve. This is in direct contradiction to the expected behaviour and that which happens when the variable is instead a scalar. Below is an MWE I will use for the whole bug report.
When I look at the equations for test_simp, the output is as follows: The fact that the variable equals itself remains and there is no observed equations. Though as said earlier, this equation is a simple equality that should be moved to observed as far as I am aware, as is done for scalars.
This then leads to what I think is a following bug which is once I create the problem, the initial vector length is twice that of the provided one. Which I assume is because of something to do with the presence of the 0 ~ ... equation.
ODEProblem with uType Vector{Float64} and tType Float64. In-place: true timespan: (0.0, 10.0) u0: 20-element Vector{Float64}: 0.0 0.0 0.0 0.0 0.0 0.0 0.0 ⋮ 0.0 0.0 0.0 0.0 0.0 0.0 0.0This is accompanied by a 'Warning: Internal error: Variable (y(t))[10] was marked as being in 0 ~ -(dy₊rhs(t))[10] + (rhs_function(y(t), a, b, t))[10], but was actually zero' performed n*n times where n is the length of y. This is I think because register symbolic wants the whole vector provided at each solve call. This is of course not required for this example but in my real work, I need the whole array sending for each individual vector point so that is why it is a registerd_symbolic_array like this.
Environment (please complete the following information):
using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)versioninfo()The text was updated successfully, but these errors were encountered: