Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other radii in Miller projection + tests #1138

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 1, 2018

Rationale

I just wanted to add tests for the Miller projection, but Snyder's examples use a different radius than the one hard-coded in Cartopy. So I added support for other radii. This meant removing the hard-coded limits, based on the equations in Snyder.

Implications

There are now tests for the Miller projection.

It does not support ellipses, so warn about that in the same way as the
Orthographic projection.
@dopplershift dopplershift merged commit ece8396 into SciTools:master Oct 2, 2018
@QuLogic QuLogic deleted the miller-radius branch October 3, 2018 00:44
@dopplershift dopplershift added this to the 0.17 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants