Update sphinx-gallery to 0.2.0 #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 24, 2018
| @@ -98,10 +98,12 @@ | |||
| release = cartopy.__version__ | |||
|
|
|||
| # Sphinx gallery configuration | |||
| from sphinx_gallery.sorting import ExampleTitleSortKey | |||
There was a problem hiding this comment.
E402 module level import not at top of file
There was a problem hiding this comment.
This warning is disabled in our setup.cfg; don't know why @stickler-ci is posting about it.
There was a problem hiding this comment.
The flake8 config is also supposed to ignore this file (assuming it is reading setup.cfg).
dopplershift
approved these changes
Oct 30, 2018
|
Any reason we can’t just ignore Stickler here? |
|
No, sorry meant to merge this earlier but I forgot... |
|
And apparently I can't merge a PR with failing tests from my phone... Please do the honours @dopplershift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We currently only support a single version of sphinx-gallery due to patching; this updates to the latest one.
Implications
I also changed the sorting to use the title of the example, which I personally think makes more sense than number of lines.