Stop guessing whether Paths are polygons on new MPL. #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this will have to wait until after #1130 since we aren't testing 2.2+ on CI yet. |
|
Can you add a test based on #1078? Or is there something here like that I’m missing? |
|
No, good point; I will add it when I rebase for new Matplotlib. |
QuLogic
force-pushed
the
path-close
branch
3 times, most recently
from
4e71dbf
to
39a9748
Compare
The main things that suffered from this are font glyphs, fixed in 2.0.1, and contours, which were fixed with Matplotlib's new contouring code. Legacy contouring was remove in 2.2.0. Also, our own geos_to_path, which was just fixed.
|
OK, rebased and added a test here. |
dopplershift
approved these changes
Nov 10, 2018
|
Once again, merging over CI for #1171. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main things that suffered from this are font glyphs, fixed in 2.0.1 (matplotlib/matplotlib#8028), and contours, which were fixed with Matplotlib's new contouring code. Legacy contouring was remove in 2.2.0 (matplotlib/matplotlib#9316).
Also, our own
geos_to_path, which was just fixed in this PR.Fixes #1078.
Fixes #158 also, I think.