Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapbox tiles interface #1170

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Conversation

DPeterK
Copy link
Member

@DPeterK DPeterK commented Nov 6, 2018

The API for accessing mapbox tiles has updated. This PR brings the cartopy mapbox tiles interface in line with the updated mapbox API, and adds a new mapbox interface for retrieving user-defined map tiles (known as "styles" in the mapbox lexicon – see https://www.mapbox.com/studio-manual/overview/map-styling/#what-is-a-style).

@dopplershift dopplershift added this to the 0.17 milestone Nov 10, 2018
Copy link
Member

@pelson pelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are you done making changes?

@pelson
Copy link
Member

pelson commented Nov 14, 2018

@pelson pelson merged commit 6cb4fa6 into SciTools:master Nov 14, 2018
@DPeterK DPeterK deleted the mapbox_api_url branch November 14, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants