Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Cython version updated #1253

Closed
pelson opened this issue Jan 3, 2019 · 5 comments
Closed

Minimum Cython version updated #1253

pelson opened this issue Jan 3, 2019 · 5 comments

Comments

@pelson
Copy link
Member

pelson commented Jan 3, 2019

Description

It seems that #1251 means that we now depend on Cython 0.29+.

The compile error I got with 0.28.5 (Linux, GCC 4.4.7):

cythoning lib/cartopy/trace.pyx to lib/cartopy/trace.cpp

Error compiling Cython file:
------------------------------------------------------------
...
        else:
            geom = GEOSGeom_createCollection_r(handle, GEOS_MULTILINESTRING,
                                               &geoms[0], geoms.size())
        return geom

    cdef list[Line].size_type size(self):
        ^
------------------------------------------------------------

lib/cartopy/trace.pyx:173:9: 'list[Line].size_type' is not a type identifier

We should either try to relax this version dependency, or document it (either is fine IMO).

cc @QuLogic

@QuLogic
Copy link
Member

QuLogic commented Jan 3, 2019

That's odd; both Travis and AppVeyor build against Cython 0.17.

@pelson
Copy link
Member Author

pelson commented Jan 4, 2019

Hmm, yes indeed. Perhaps it isn't as simple as the Cython version. I was using a pretty old GCC there, so there may be more to it. For others that come across this issue (via Google), upgrading to Cython v0.29 did solve the issue for me.

@QuLogic
Copy link
Member

QuLogic commented Jan 15, 2019

Here's a build where I pass --no-build-isolation and it fails as yours did: https://travis-ci.org/QuLogic/cartopy/builds/479829383 This switch seems to have been quietly hiding some subtle bugs.

@QuLogic
Copy link
Member

QuLogic commented Jan 15, 2019

I'd like to see if we can still support Cython 0.28 as that's what's in current Fedora and Debian testing.

@pelson
Copy link
Member Author

pelson commented Jan 15, 2019

I'd like to see if we can still support Cython 0.28 as that's what's in current Fedora and Debian testing.

With #1264 you don't need Cython at all if you are using the sdist? Is that helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants