Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciPy dependency #1697

Closed
dopplershift opened this issue Dec 21, 2020 · 2 comments · Fixed by #1876
Closed

SciPy dependency #1697

dopplershift opened this issue Dec 21, 2020 · 2 comments · Fixed by #1876

Comments

@dopplershift
Copy link
Contributor

Description

Currently we unconditionally import scipy in two places:

try:
import pykdtree.kdtree
_is_pykdtree = True
except ImportError:
import scipy.spatial
_is_pykdtree = False

(when no pykdtree) and here:

import numpy as np
from scipy.interpolate import griddata

That would contradict where we list scipy as an "optional" dependency. We should either update the docs in INSTALL or handle those imports differently.

@dopplershift dopplershift added this to the 0.19 milestone Dec 21, 2020
@QuLogic QuLogic modified the milestones: 0.19, 0.20 Apr 22, 2021
@jackieleng
Copy link

Ran into this issue today. Followed the installation guide and thought I installed all deps. Tried running the animate_surface.ipynb notebook, but failed, because I have no pykdtree nor scipy installed

@greglucas
Copy link
Contributor

We also list matplotlib as an optional dependency, which seems a bit odd :) So, that should probably be updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants