Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .prj for NaturalEarth data #1744

Closed
tfardet opened this issue Mar 11, 2021 · 2 comments · Fixed by #1745
Closed

Missing .prj for NaturalEarth data #1744

tfardet opened this issue Mar 11, 2021 · 2 comments · Fixed by #1745

Comments

@tfardet
Copy link
Contributor

tfardet commented Mar 11, 2021

Description

With the current default downloader from cartopy, not all elements from the NaturalEarth zip container are extracted.
Currently, only shp, dbf, and shx are present.

This means that when loading the file (e.g. in my case with geopandas.read_file) leads to a GeoDataFrame that has its crs element set to None instead of "epsg:4326".

Feature request

Unless there is a good reason not to include the .prj file (that has already been downloaded anyways), I'd suggest to include it in the list of extensions there.
Given that it takes virtually no space, I'd also suggest to include the .cpg in case it might also be of use to somebody somewhere.

I can provide a PR if necessary.

@dopplershift
Copy link
Contributor

That sounds reasonable—a PR implementing it would be welcome.

@tfardet
Copy link
Contributor Author

tfardet commented Mar 12, 2021

See #1745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants