Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp312 wheels ? #2271

Closed
neutrinoceros opened this issue Oct 13, 2023 · 6 comments
Closed

cp312 wheels ? #2271

neutrinoceros opened this issue Oct 13, 2023 · 6 comments
Milestone

Comments

@neutrinoceros
Copy link
Contributor

neutrinoceros commented Oct 13, 2023

Hi, is there a timeline for when CPython 3.12 wheels will be published ?
I'm asking because such wheels would be helpful to test downstream code more efficiently, but as far as I am concerned there's no rush.
I note that shapely 2.0.2 was just released with cp312 wheels, which I assume was necessary condition for you guys to get started ? I'd be happy to submit a PR to update CI and wheel-building workflows.

@djhoese
Copy link

djhoese commented Oct 13, 2023

I'm not a maintainer of this project, but am looking through various dependencies that I need for Python 3.12 support on my own project. I think the first step is to figure out why the tests are failing on:

#2257

It looks like these tests passed in the original cibuildwheel update and one that included Python 3.12:

#2244

I don't know enough about cartopy's build process to make a guess as to what is going on. One #2257 is passing then cp312 can be added to the build environment variable. Assuming that build passes then it should just require a release of cartopy to get the wheels you want.

Given the limited time of the maintainers this may be difficult to get done unless someone outside the maintainer team has all the answers to what is currently going wrong.

@jfrost-mo
Copy link

Looks like they have been merged now, so we just need to wait for a release.

@rcomer
Copy link
Member

rcomer commented Oct 27, 2023

@jfrost-mo if you are using conda, I think it is already covered thanks to @djhoese
conda-forge/cartopy-feedstock#157

@jfrost-mo
Copy link

jfrost-mo commented Oct 27, 2023

Ooh. excellent. I'll give it a go then.

@jfrost-mo
Copy link

I can confirm that the conda package works for python 3.12 now. And thus iris works for 3.12. 🎉

@rcomer
Copy link
Member

rcomer commented Apr 10, 2024

Cartopy 0.23 was just released and python 3.12 wheels are up on PyPI 🎉

@rcomer rcomer closed this as completed Apr 10, 2024
@QuLogic QuLogic added this to the 0.23 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants