Performance Shift(s): 89ed9eec

[github-actions]

Benchmark comparison has identified performance shifts at commit 89ed9ee (#4658). Please review the report below and take corrective/congratulatory action as appropriate 🙂

Performance shift report

       before           after         ratio
     [c2135160]       [89ed9eec]
     <main~2>         <main~1>  
+      6.29±0.2ms       8.17±0.2ms     1.30  cube.AuxFactory.time_add

Generated by GHA run 2037078661

[wjbenfold]

Going to go ahead and say that's not my fault. Should I do anything else or just shut it @trexfeathers?

[trexfeathers]

Disappointing - this is the first false positive for a benchmark that I 'trust' to produce meaningful results.

But you've demonstrated how we as humans can easily judge when it is a false positive. If they show up too often we'll have to rethink the minimum ratio to avoid too much noise, which would be a shame because sometimes a 1.2 shift is actually significant.

Closing.

[wjbenfold]

I guess it's an argument against having too many, even if we have the time to run them now, because each one will up the probability that we get a false positive off a given run