Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for scalar cubes before attempting to concatenate a CubeList #4941

Open
valeriupredoi opened this issue Sep 5, 2022 · 7 comments
Open

Comments

@valeriupredoi
Copy link

valeriupredoi commented Sep 5, 2022

📰 Custom Issue

Hi guys, a variation on the theme of concatenation/merge on which there are a few issues already open - it'd be nice if iris handled scalar cubes as big bad wolves and looked for them in, say, a CubeList to be concatenated/merged, and raise a nice exception that identifies that (or those) scalar cubes - I recently found out that scalar cubes produce havoc when one tries to concatenate - raised (inadvertently) by @bouweandela in this comment - it all happens in _io._concatenate_overlapping_cubes(cubes) - after extract_time() (one of our utilities) the resulting cube may be scalar - so iris concatenation fails due to scalar cubes not having dim_metadata attributes in iris._concatenate_CubeSignature class (they do, but they are empty lists).

Cheers muchos 🍺

@pp-mo
Copy link
Member

pp-mo commented Sep 7, 2022

#3234 seems relevant

So, we also labelled "Feature: merge+concat"
It's not clear when we can do this,
But let's leave it open for now.

ALSO: can consider this + similar issues around time of forthcoming ESMValTool workshop [Oct 18-20 2022]

@valeriupredoi
Copy link
Author

cheers @pp-mo 🍺 Indeed, let's add it to the workshop!

@valeriupredoi
Copy link
Author

valeriupredoi commented Sep 8, 2022

@pp-mo I have created a discussion point on the ESMValTool discussions pages that can hold a list of all these types of issues to be discussed at the call on next Monday, and the wkshp, if you got a bit of time it'd be nice to populate that list with what you reckon could be discussed - or, label these issues with some specific label so I can pull them over there. Cheers muchly as ever 🍺 ESMValGroup/ESMValTool#2792

@pp-mo
Copy link
Member

pp-mo commented Sep 8, 2022

... label these issues with some specific label so I can pull them over there.

We do have the "Feature: ESMValTool" label.

I just added that one to a few more existing Iris tickets.
I think that now covers everything we know about so far, that is of relevance to ESMValTool i.e. one of you expressed interest.
Feel free to add to other issues if they have interest for you, and we didn't already know it.

@pp-mo
Copy link
Member

pp-mo commented Sep 9, 2022

We do have the "Feature: ESMValTool" label.

@bjlittle also reminds me -- we also have a Scitools project, though TBH we haven't paid much attention to it lately.

@bouweandela
Copy link
Member

We discussed this issue a bit in the ESMValTool community, and the request is mostly about a nicer error message. @valeriupredoi Could you provide an example of the error message and explain why it is not clear and how you think it could be improved?

Copy link
Contributor

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue/pull-request label Feb 13, 2024
@stephenworsley stephenworsley removed the Stale A stale issue/pull-request label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

4 participants