Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge to accept variable_name clashes #512

Closed
marqh opened this issue May 20, 2013 · 2 comments
Closed

merge to accept variable_name clashes #512

marqh opened this issue May 20, 2013 · 2 comments
Assignees
Labels
Feature: Merge/Concatenate Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton Status: Duplicate

Comments

@marqh
Copy link
Member

marqh commented May 20, 2013

This discussion highlighted that variable names loaded from NetCDF files are used in the comparison of candidate cubes during merge.

Variable names are not semantic containers, they are just labels, and should not be treated in this way. This needs to be implemented for cubes and coordinates, both exhibit the behaviour.

Update merge such that it:

  • preserves 1 variable name if it is consistent across all candidate cubes/coordinates
  • removes variable names from candidate cubes/coordinates if they differ, enabling merging to occur

Test suggestion: slice a cube into a cubelist and save the cubelist as a NetCDF file. Load the NetCDF file and assert that the merge result in 1 cube, ignoring the differing variable names.

@pelson
Copy link
Member

pelson commented Oct 14, 2013

Sorry I'm late to the party, but I'm just writing the merge section of the Iris course and I'm 👍 on this. I'd like to see this addressed asap, @rhattersley - can you add this to our todo for the next couple of weeks?

@bjlittle bjlittle self-assigned this Oct 1, 2020
@bjlittle bjlittle added the Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton label Oct 1, 2020
@trexfeathers
Copy link
Contributor

Duplicate of #4446

@trexfeathers trexfeathers marked this as a duplicate of #4446 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Merge/Concatenate Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton Status: Duplicate
Projects
None yet
Development

No branches or pull requests

5 participants