Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken git links in developer guide #5336

Closed
rcomer opened this issue May 31, 2023 · 3 comments
Closed

Broken git links in developer guide #5336

rcomer opened this issue May 31, 2023 · 3 comments
Assignees

Comments

@rcomer
Copy link
Member

rcomer commented May 31, 2023

📚 Documentation

Our Development Workflow page has various links to documentation for git commands. Those links are defined here:

.. _git clone: http://schacon.github.com/git/git-clone.html
.. _git checkout: http://schacon.github.com/git/git-checkout.html
.. _git commit: http://schacon.github.com/git/git-commit.html
.. _git push: http://schacon.github.com/git/git-push.html
.. _git pull: http://schacon.github.com/git/git-pull.html
.. _git add: http://schacon.github.com/git/git-add.html
.. _git status: http://schacon.github.com/git/git-status.html
.. _git diff: http://schacon.github.com/git/git-diff.html
.. _git log: http://schacon.github.com/git/git-log.html
.. _git branch: http://schacon.github.com/git/git-branch.html
.. _git remote: http://schacon.github.com/git/git-remote.html
.. _git rebase: http://schacon.github.com/git/git-rebase.html
.. _git config: http://schacon.github.com/git/git-config.html

http://schacon.github.com gives a 404.

It's ignored by the linkcheck

"http://schacon.github.com/git",

@rcomer
Copy link
Member Author

rcomer commented Jun 12, 2023

My original thought when I saw this was that we should update these links to point to equivalent documentation on another site. But now I’m thinking maybe we should just remove them: git is a lot more mainstream than it was a decade ago, and I think we can reasonably expect contributors to google* those commands if they want more details.

*other search engines are available

@tkknight
Copy link
Contributor

tkknight commented Nov 8, 2023

#5569 created to remove the broken git links.

@rcomer
Copy link
Member Author

rcomer commented Nov 8, 2023

Closed by #5569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants