Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve utility of warnings in Iris tests #5466

Open
3 of 11 tasks
trexfeathers opened this issue Sep 5, 2023 · 1 comment
Open
3 of 11 tasks

Improve utility of warnings in Iris tests #5466

trexfeathers opened this issue Sep 5, 2023 · 1 comment

Comments

@trexfeathers
Copy link
Contributor

trexfeathers commented Sep 5, 2023

Story

  • As a
    Iris developer
  • I want
    Warnings that are a problem for Iris to result in CI failure (e.g. a DeprecationWarning)
  • So that
    I can address problems introduced by new commits proactively and immediately (rather than reactively when issues are discovered downstream)

Notes

#4384

Iris Gallery includes (or has included!) code to convert warnings to failures/errors.

Ideas

  • Suppress warnings we know are not a problem, so only those that matter are left. Then set a test run to exit non-0 if any warnings are raised. Would likely need to address quite a few warnings before this could start working!
  • A custom routine that causes a failure if it detects warnings of known categories (might only be DeprecationWarning?).

From discussion

  • Cost-benefit is difficult. Focussing on DeprecationWarning would be fairly easy, but is it offering much. Covering all warnings may need a lot of leg work to adapt the tests.
  • Should start by seeing how many tests fail if warnings are 'promoted', and see how this informs further discussions.

Tasks

  1. ESadek-MO acchamber
  2. Type: Infrastructure
    ESadek-MO trexfeathers
  3. Type: Bug
  4. Type: Infrastructure
  5. Type: Infrastructure
  6. Type: Infrastructure
  7. Type: Infrastructure
  8. Type: Infrastructure
  9. Type: Infrastructure
  10. Type: Infrastructure Type: Testing
@ESadek-MO
Copy link
Contributor

Note: have converted write up from #5465 into issues and added as subtasks on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: User Story
Status: No status
Development

No branches or pull requests

2 participants