Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Drop txmongo support? #381

Open
whophil opened this issue Sep 18, 2022 · 3 comments
Open

[RFC] Drop txmongo support? #381

whophil opened this issue Sep 18, 2022 · 3 comments

Comments

@whophil
Copy link
Collaborator

whophil commented Sep 18, 2022

It seems txmongo is increasingly hard to support.

txmongo cannot be imported with pymongo >= 4 (see twisted/txmongo#278)

Even if the import issues are fixed, txmongo internally uses an OP_QUERY command which is incompatible with Mongo server instances >= 6.0 (see https://www.mongodb.com/docs/manual/reference/mongodb-wire-protocol/#footnote-op-query-footnote).

txmongo is not actively developed.

Should txmongo support remain, or just be deprecated?

@lafrech
Copy link
Collaborator

lafrech commented Sep 19, 2022

Hi.

If you think you can fix txmongo easily and get away with it for a few months, then it may be worth doing. But otherwise, let's not carry the burden of a lib that is not actively maintained.

Since dropping it would be a breaking change, you may want to ship a major release. Time to see what other issue we could cram in there (probably none).

Or maybe just don't bother, pin the pymongo version in the tests and ensure CI runs on appropriate MongoDB version if that is not too hard. And yes, as you said, add a deprecation notice for future removal, so we get to see if someone takes over txmongo development. If nobody does, then dropping it is the way to go.

@lafrech lafrech pinned this issue Sep 19, 2022
@lafrech lafrech changed the title Continuing txmongo support? [RFC] Drop txmongo support? Sep 19, 2022
@psi29a
Copy link

psi29a commented Feb 1, 2023

We're (maintainers) still around, just had a lot of life issues in the way. We do accept PRs. We're now in the process of migrating away from travis-ci to github actions. We also have support for later versions of mongodb in the works as well.

@psi29a
Copy link

psi29a commented Sep 30, 2024

twisted/txmongo#290 merged; will release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants