Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename #toString......... again #117

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments
Closed

rename #toString......... again #117

GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Discussion at ESUG suggests #toString is going to conflict with other code.

#asSeasideString or similar was suggested.

Original issue reported on code.google.com by [email protected] on 28 Aug 2008 at 12:47

@GoogleCodeExporter
Copy link
Author

What about #seasideAsString or #waAsString?

Original comment by [email protected] on 28 Aug 2008 at 1:40

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 29 Aug 2008 at 7:23

  • Added labels: Priority-Critical, Version-Seaside2.9
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

How would #toString conflict with other code?

Original comment by [email protected] on 29 Aug 2008 at 10:17

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Niall and John did a quick examination of VW, the dialect that dislikes 
Object>>asString.  The problem is a couple of methods on GenericException that 
do 
not know whether an evaluable object (probably a block) has been passed in or a 
String-like object.  Object already responds to value (thanks to the Squeak 
porting 
layer) so they use whether the instance responds to asString to distinguish the 
two 
classes of object.

This should be changed to eliminate respondsTo: in favour of isEvaluable or 
similar.  Niall will raises this as a possible 7.7 fix;  for something as 
fundamental as exceptions, it may not be a quick patch earlier but watch this 
space.

First cut summary, to be reviewed, is:
- endure another method name
- expect to rename back to asString when VW can endure that

Original comment by [email protected] on 29 Aug 2008 at 1:12

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This is fixed in upstream.

All affected packages have been committed with the comment: "- #toString 
renamed to #seasideString"

Original comment by renggli on 30 Aug 2008 at 2:32

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant