Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several packages have soft dependencies on the Session package #215

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 9 comments
Closed

Comments

@GoogleCodeExporter
Copy link

They either call WAObject>>application or WAObject>>session, which are not
available if you don't have the Session package loaded. Core, Canvas, and
Component packages should all, theoretically at least, be useable without
Session.

Problematic senders of #application:
WARenderingContext>>registry -- add registry instvar to the context?
WARenderingContext>>absoluteUrlForResource: -- maybe just move into session
package, though session should not depend on canvas. Really we need class
extensions that are applied *if* you have the relevant class loaded but not
otherwise. Also there are 6 senders of this message. Maybe we need to also
store a resource base URL on the rendering context.
WABasicFormTag>>multipart -- how can it get a chartSet? from the Response
in the request context? from the rendering context?
WAResponse>>initialize -- same problem as above. maybe this stuff needs to
be on the request context...

Problematic senders of #session:
WAComponent>>filterWith:during:

Original issue reported on code.google.com by [email protected] on 20 Oct 2008 at 3:15

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 20 Oct 2008 at 3:15

  • Added labels: Version-Seaside2.9
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 4 Jan 2009 at 10:43

  • Added labels: Dependencies
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Regarding the senders of #session: in Seaside-Component, #filterWith:during:,
#authenticateWith:during:, and #isolate: can all be moved either to
Seaside-RenderLoop as class extensions or directly onto WASession.

Other than compatibility with "self isolate:", I see no reason these need to be
methods on Component. We could just deprecate WAComponent>>isolate: and point 
it at
WASession>>isolate:. What does anybody else think?

Original comment by [email protected] on 3 Feb 2009 at 11:33

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Upon further thought, #filterWith:during:, #authenticateWith:during:, and 
#isolate:
only really make sense when used with Flow. I've left them on Component for now 
but
put them in the Seaside-Flow package.

Of the original list in this issue, only the following problems remain:
  WARenderingContext>>absoluteUrlForResource:
  WABasicFormTag>>multipart

Original comment by [email protected] on 9 Feb 2009 at 4:35

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I addressed WARenderContext>>absoluteUrlForResource:. The only remaining issue 
from
the original list should be WABasicFormTag>>multipart



Name: Seaside-Canvas-jf.53
Author: jf
Time: 21 February 2009, 7:05:58 pm
UUID: 5cc2bdf6-6c13-4107-a818-4062e501b9ba
Ancestors: Seaside-Canvas-jf.52

Name: Seaside-Core-jf.493
Author: jf
Time: 21 February 2009, 7:06:06 pm
UUID: 1a15d0e2-4290-4fa5-a85c-9e43aa6ffa26
Ancestors: Seaside-Core-pmm.492

Name: Seaside-RenderLoop-jf.58
Author: jf
Time: 21 February 2009, 7:06:21 pm
UUID: 91ec7d99-f9bc-4bdb-90ae-8358c6b5f301
Ancestors: Seaside-RenderLoop-jf.57

Name: Seaside-Tests-Canvas-jf.23
Author: jf
Time: 21 February 2009, 7:06:29 pm
UUID: 420a7b88-80ae-43e8-b7fc-9f2509c79be3
Ancestors: Seaside-Tests-Canvas-jf.22

Name: Seaside-Tests-Core-jf.116
Author: jf
Time: 21 February 2009, 7:06:36 pm
UUID: 911b6ae9-5caf-43ed-ade6-3015d22cd307
Ancestors: Seaside-Tests-Core-pmm.115

Name: Seaside-Tests-Session-jf.22
Author: jf
Time: 21 February 2009, 7:06:44 pm
UUID: dcd46dbd-d72f-4829-a19f-c989462344f2
Ancestors: Seaside-Tests-Session-lr.21

Original comment by [email protected] on 21 Feb 2009 at 6:08

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This should be solvable if the encoding setting is moved from Application to the
ServerAdaptor.

Original comment by [email protected] on 27 Feb 2009 at 7:31

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 4 Sep 2009 at 8:45

  • Added labels: Milestone-3.0b1
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 4 Sep 2009 at 3:49

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Move #charSet up from WAApplication to WAEntryPoint. Update senders and
configurations accordingly.



Name: JQuery-Core-yann_monclair.80
Author: yann.monclair
Time: 4 September 2009, 5:48:56 pm
UUID: e81201cd-b979-e545-b843-43d92dd92fe9
Ancestors: JQuery-Core-lr.79

Name: Prototype-Core-yann_monclair.7
Author: yann.monclair
Time: 4 September 2009, 5:49:26 pm
UUID: 59609601-6997-3e46-b934-5e99a488a1c8
Ancestors: Prototype-Core-jf.6

Name: RSS-Core-yann_monclair.52
Author: yann.monclair
Time: 4 September 2009, 5:49:54 pm
UUID: 5be418c3-0916-ce49-a4e5-2dc51d855615
Ancestors: RSS-Core-jf.51

Name: Seaside-Canvas-yann_monclair.67
Author: yann.monclair
Time: 4 September 2009, 5:50:21 pm
UUID: 1052748f-b533-034e-8399-c9d97bbd1cf9
Ancestors: Seaside-Canvas-NickAger.66

Name: Seaside-Core-yann_monclair.545
Author: yann.monclair
Time: 4 September 2009, 5:50:42 pm
UUID: 38637784-ecef-e84b-890a-e5d6f5428f5f
Ancestors: Seaside-Core-lr.544

Name: Seaside-Session-yann_monclair.115
Author: yann.monclair
Time: 4 September 2009, 5:51:02 pm
UUID: 59dc0d95-88a1-6549-94f9-3412cb91bb99
Ancestors: Seaside-Session-pmm.114

Name: Seaside-Tests-Canvas-yann_monclair.30
Author: yann.monclair
Time: 4 September 2009, 5:51:29 pm
UUID: 9289b840-8216-0a4a-be85-061af59ccbc6
Ancestors: Seaside-Tests-Canvas-NickAger.29

http://code.google.com/p/seaside/issues/detail?id=215

http://code.google.com/p/seaside/issues/detail?id=445

Move #charSet up from WAApplication to WAEntryPoint. Update senders and
configurations accordingly.

Original comment by [email protected] on 4 Sep 2009 at 3:55

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant