Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WABatchedList>>hasJustOnePage #244

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments
Closed

WABatchedList>>hasJustOnePage #244

GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Please provide the following testing method:

WABatchedList>>hasJustOnePage
  ^ self maxPages = 1

Original issue reported on code.google.com by [email protected] on 19 Nov 2008 at 2:40

@GoogleCodeExporter
Copy link
Author

What would be a user of this method?

The only potential user I see is #renderContentOn:. But that would require a 
change
in the behavior from not showing the batch if there are no items (current) to 
not
showing the batch if there is just one page. However is this case 
#hasMoreThanOnePage
would be more convenient.

Original comment by [email protected] on 1 Dec 2008 at 8:38

  • Added labels: Priority-Low, Type-Feature
  • Removed labels: Priority-Medium, Type-Defect

@GoogleCodeExporter
Copy link
Author

I guess a user of WABatchedList wants to externally decide to display the batch 
or not.

I would argue that a selector name like #hasMultiplePages would be even better.

Original comment by renggli on 2 Dec 2008 at 7:15

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

PBBlogHtmlView>>renderBatcherOn: html
  (self batcher isOnFirstPage and: [ self batcher isOnLastPage ])
    ifFalse: [ html div class: 'batcher'; with: self batcher ]

Original comment by [email protected] on 2 Dec 2008 at 8:36

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Name: Seaside-Widgets-pmm.27
Author: pmm
Time: 28 August 2011, 5:17:22 pm
UUID: 5c1bb851-da6b-4f9f-ad2b-7c2dd535fb62
Ancestors: Seaside-Widgets-lr.26

- Issue 244:    WABatchedList>>hasJustOnePage

Original comment by [email protected] on 28 Aug 2011 at 4:18

  • Changed state: Fixed
  • Added labels: Version-Seaside3.1
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I went with #hasMultiplePages

Original comment by [email protected] on 28 Aug 2011 at 4:19

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant