Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix load scripts in callback phase #40

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 6 comments
Closed

fix load scripts in callback phase #40

GoogleCodeExporter opened this issue Mar 25, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

Since the J2EE refactoring load scripts added to the context during the
callback phase are forgotten.

Original issue reported on code.google.com by [email protected] on 29 Mar 2008 at 4:23

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 15 Jul 2008 at 9:21

  • Added labels: Priority-Critical
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Does anybody see a better solution than temporarily adding them to the session 
during
the callback phase?

Original comment by [email protected] on 15 Jul 2008 at 6:01

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This is ugly. Are there actual places where scripts are added during callbacks? 
I don't think we should support 
that.

Original comment by renggli on 15 Jul 2008 at 6:50

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I agree on the ugliness. I loaded everything I could from SeaChart which does a 
load
of JS trickery and all #addLoadScript: senders were in the rendering phase. So 
it
looks ok to remove.

Original comment by [email protected] on 15 Jul 2008 at 7:20

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I will see if we can add a Slime check for that.

Original comment by renggli on 15 Jul 2008 at 7:24

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Slime check already exists.

Original comment by [email protected] on 30 Aug 2008 at 4:01

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant