Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response generators have to reset the response before generating a new one #676

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. add {{{1 / 0}}} at the bottom of {{{WACuounter >> #renderContentOn:}}}
2. go to http://127.0.0.1:8080/examples/counter

What is the expected output? What do you see instead?
You should just see the contents the response generator generated but you also 
see everything rendered previously.

The response generator needs to do something along the lines of {{{response 
stream reset}}} maybe also reset the header. We will also need a {{{#reset}}} 
method on {{{GRCodecStream}}}

Original issue reported on code.google.com by [email protected] on 18 Aug 2011 at 10:49

@GoogleCodeExporter
Copy link
Author

And we'll have to take streaming servers into account which do not support this 
if the response is already committed.

Original comment by [email protected] on 18 Aug 2011 at 10:51

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Hmm... while rendering, it can be useful to see how far the rendering got 
before there was an error. Though I guess it's not desired in production and 
during development you'd rather just have a debugger, so probably you're right.

Original comment by [email protected] on 19 Aug 2011 at 1:23

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 25 Aug 2011 at 12:57

  • Added labels: Version-Seaside3.1
  • Removed labels: Version-Seaside3.0

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 25 Aug 2011 at 12:57

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

ಠ_ಠ streams are buggy in Pharo

Original comment by [email protected] on 25 Aug 2011 at 1:21

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author



Name: Seaside-Environment-pmm.78
Author: pmm
Time: 26 August 2011, 5:07:56 pm
UUID: 3e3f0ba6-7bc9-477a-9779-966246dca3dc
Ancestors: Seaside-Environment-pmm.77

- Issue 676:    response generators have to reset the response before generating 
a new one
- update response generators

Name: Seaside-Environment-pmm.78
Author: pmm
Time: 26 August 2011, 5:07:56 pm
UUID: 3e3f0ba6-7bc9-477a-9779-966246dca3dc
Ancestors: Seaside-Environment-pmm.77

- Issue 676:    response generators have to reset the response before generating 
a new one
- update response generators

Original comment by [email protected] on 27 Aug 2011 at 4:53

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 28 Aug 2011 at 11:38

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant