Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQDialog>>#buttons: #708

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 1 comment
Closed

JQDialog>>#buttons: #708

GoogleCodeExporter opened this issue Mar 25, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

I think that the parameter name and comment is misleading for 
JQDialog>>#buttons: Current it reads:

----
buttons: anArray
    "Specifies which buttons should be displayed on the dialog. Each element of the array must be an Object defining the properties to set on the button."

    self optionAt: 'buttons' put: anArray
----

IIUC #buttons should take a dictionary so read:

----
buttons: aDictionary
    "Specifies which buttons should be displayed on the dialog. The keys of the dictionary define the text to display on the button and the values of the dictionary define the action to be taken when the button is pressed"

    self optionAt: 'buttons' put: aDictionary
----

I check-in a change myself, but I remember that some of the Seaside jQuery 
integration is automated so would the change be overwritten by an automated 
update? 



Original issue reported on code.google.com by [email protected] on 24 Jan 2012 at 11:35

@GoogleCodeExporter
Copy link
Author

The code to generate the methods from the docs is at JQWidget class>>#generate. 
The code does not change methods that are not in a *-generated category, so we 
could manually change this method and move it out of its category. Now 
documentation in JQueryUI also changed, it proposed to replace 'buttons: 
anArray' with 'buttons: anObject'. Now this is obviously not perfect, but 
already better. I integrated that suggestion.

Original comment by renggli on 19 Feb 2012 at 12:24

  • Changed state: Fixed
  • Added labels: Version-Seaside3.1
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant