Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiversion value used for Google Map API version is no more supported by Google Map API versioning #1573

Closed
jlj44 opened this issue Jan 11, 2019 · 2 comments
Closed

apiversion value used for Google Map API version is no more supported by Google Map API versioning #1573

jlj44 opened this issue Jan 11, 2019 · 2 comments

Comments

@jlj44
Copy link

jlj44 commented Jan 11, 2019

Issue description
Google Map API version is defined in github in .../packages/core/services/maps-api-loader/lazy-maps-api-loader.ts.
And it is written 'v: this._config.apiVersion || '3' ', that means that the parameter used is 'v=3'.
I have checked in Google Map API versioning documentation what it is the definition of 'v=3' : https://developers.google.com/maps/documentation/javascript/versions. That value is not defined.
I have asked on a dedicated forum about the google-map-api-v3 and the answer is : "That used to be how google suggested requesting the "release" version of the API (before the weekly/quarterly versions were added) from an old version of the documentation on archive.org: https://web.archive.org/web/20160611023838/https://developers.google.com/maps/documentation/javascript/versions."
As mentionned in the new Google Map API versioning , "If you do not explicitly specify a channel or version, you will receive the weekly channel by default" (v=weekly). As 'v=3' is no more supported by Google Map API versioning, it means that it is like v=weekly (channel for current release).
So my recommandation will be to change in AGM code 'v=3' by 'v=weekly' that corresponds to the new Google Map API versioning (refer also to the releases https://developers.google.com/maps/documentation/javascript/releases).

Steps to reproduce and a minimal demo of the problem

_Use https://plnkr.co or similar -- try this template as a starting point: http://plnkr.co/edit/YX7W20?p=preview

What steps should we try in your demo to see the problem?

Current behavior
"v=3"

Expected/desired behavior
"v=weekly" to be compliant with the new Google Map API versioning (refer also to the releases https://developers.google.com/maps/documentation/javascript/releases).

angular2 & angular-google-maps version

Other information
@sebholstein
Copy link
Owner

Thanks for the report,

I think we should use the quarterly option as a default because that gives us more predictability. When someone wants to get the latest feature, he/she can override the version.

@sebholstein sebholstein mentioned this issue Jan 20, 2019
Merged
sebholstein added a commit that referenced this issue Jan 20, 2019
@sebholstein
feat(GoogleMapsAPILoader): change default API version (#1577)
2fc1a21 
This changes the default version of the Google Maps API to `quarterly`
because the Google Maps team changed the version strategy.

closes #1573

BREAKING CHANGES

This could change the Google Maps API version - so please check if you
need to change the setting of the `apiVersion` attribute in the
`AgmCodeModule.forRoot()` call.
@jlj44
Copy link
Author

jlj44 commented Jan 21, 2019

Thanks Sebastian. I am agreed with you. Kind Regards, JL Jordan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebholstein @jlj44