Skip to content

Commit

Permalink
feat(angular2): add angular2.0.0-alpha.52 support
Browse files Browse the repository at this point in the history
- All Angular2 peer dependencies are now also angular2-google-maps
dependencies.

- rx package gets replaced with rxjs package
  • Loading branch information
sebholstein committed Dec 10, 2015
1 parent 9a3d33b commit 8a1d813
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 16 deletions.
7 changes: 3 additions & 4 deletions gulp/bundle.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ const bundleConfig = {
defaultJSExtensions: true,
paths: {
'angular2/*': path.join(__dirname, '../node_modules/angular2/*'),
'@reactivex/*': path.join(__dirname, '../node_modules/angular2/node_modules/@reactivex/*'),
'rx': path.join(__dirname, '../node_modules/rx/dist/rx.all.js'),
'rxjs/*': path.join(__dirname, '../node_modules/rxjs/*'),
},
};

Expand All @@ -23,7 +22,7 @@ function bundle(moduleName, outputFile, outputConfig) {

gulp.task('bundle:cjs', ['scripts:cjs'], function cleanDist(done) {
const distFileName = path.join(config.PATHS.dist.bundles, 'angular2_google_maps.js');
bundle('angular2_google_maps/angular2_google_maps - angular2/* - @reactivex/*', distFileName, {
bundle('angular2_google_maps/angular2_google_maps - angular2/* - rxjs/*', distFileName, {
sourceMaps: true,
}).then(() => {
gulp.src(distFileName)
Expand All @@ -33,7 +32,7 @@ gulp.task('bundle:cjs', ['scripts:cjs'], function cleanDist(done) {
});

gulp.task('bundle:cjs-min', ['scripts:cjs'], function cleanDist() {
bundle('angular2_google_maps/angular2_google_maps - angular2/* - @reactivex/*', path.join(config.PATHS.dist.bundles, 'angular2_google_maps.min.js'), {
bundle('angular2_google_maps/angular2_google_maps - angular2/* - rxjs/*', path.join(config.PATHS.dist.bundles, 'angular2_google_maps.min.js'), {
sourceMaps: true,
minify: true,
});
Expand Down
9 changes: 8 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,16 @@
"url": "https://github.com/SebastianM/angular2-google-maps/issues"
},
"homepage": "https://github.com/SebastianM/angular2-google-maps#readme",
"dependencies": {
"angular2": "^2.0.0-alpha.52",
"es6-promise": "^3.0.2",
"es6-shim": "^0.33.3",
"reflect-metadata": "0.1.2",
"rxjs": "5.0.0-alpha.14",
"zone.js": "0.5.8"
},
"devDependencies": {
"@reactivex/rxjs": "5.0.0-alpha.10",
"angular2": "2.0.0-alpha.46",
"babel-eslint": "4.1.6",
"conventional-github-releaser": "0.5.0",
"del": "2.2.0",
Expand Down
4 changes: 2 additions & 2 deletions src/components/google_map_marker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class SebmGoogleMapMarker implements OnDestroy, OnChanges {

constructor(private _markerManager: MarkerManager) { this._id = (markerId++).toString(); }

onChanges(changes: {[key: string]: SimpleChange}) {
ngOnChanges(changes: {[key: string]: SimpleChange}) {
if (!this._markerAddedToManger && this.latitude && this.longitude) {
this._markerManager.addMarker(this);
this._markerAddedToManger = true;
Expand All @@ -36,5 +36,5 @@ export class SebmGoogleMapMarker implements OnDestroy, OnChanges {

toString(): string { return 'SebmGoogleMapMarker-' + this._id.toString(); }

onDestroy() { this._markerManager.deleteMarker(this); }
ngOnDestroy() { this._markerManager.deleteMarker(this); }
}
1 change: 0 additions & 1 deletion src/custom_typings/typings.d.ts

This file was deleted.

16 changes: 8 additions & 8 deletions src/services/google_maps_api_wrapper.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Injectable} from 'angular2/angular2';
import {Observable} from 'rx';
import {Injectable, Observable} from 'angular2/angular2';
import {Observer} from 'rxjs/Observer';

import {MapsAPILoader} from './maps_api_loader/maps_api_loader';

Expand Down Expand Up @@ -30,25 +30,25 @@ export class GoogleMapsAPIWrapper {
});
}

createEventObservable<E>(eventName: string, callback: (observer: Rx.Observer<E>) => void):
createEventObservable<E>(eventName: string, callback: (observer: Observer<E>) => void):
Observable<E> {
return Observable.create((observer: Rx.Observer<E>) => {
return Observable.create((observer: Observer<E>) => {
this._map.then(
(m: google.maps.Map) => m.addListener(eventName, () => { callback(observer); }));
});
}

private _createObservables() {
this._centerChangeObservable = this.createEventObservable<google.maps.LatLngLiteral>(
'center_changed', (observer: Rx.Observer<google.maps.LatLngLiteral>) => {
'center_changed', (observer: Observer<google.maps.LatLngLiteral>) => {
this._map.then((map: google.maps.Map) => {
const center = map.getCenter();
observer.onNext({lat: center.lat(), lng: center.lng()});
observer.next({lat: center.lat(), lng: center.lng()});
});
});
this._zoomChangeObservable =
this.createEventObservable<number>('zoom_changed', (observer: Rx.Observer<number>) => {
this._map.then((map: google.maps.Map) => { observer.onNext(map.getZoom()); });
this.createEventObservable<number>('zoom_changed', (observer: Observer<number>) => {
this._map.then((map: google.maps.Map) => { observer.next(map.getZoom()); });
});
}

Expand Down

0 comments on commit 8a1d813

Please sign in to comment.