Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): support angular2.0.0-rc.1 #339

Closed
wants to merge 4 commits into from
Closed

(feat): support angular2.0.0-rc.1 #339

wants to merge 4 commits into from

Conversation

carl09
Copy link
Contributor

@carl09 carl09 commented May 12, 2016

(feat): support angular2.0.0-rc.1

updated library to use angular2.0.0-rc.1 for issue #331

@GitCop
Copy link

GitCop commented May 12, 2016

There were the following issues with your Pull Request

  • Commit: 636a19a
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented May 12, 2016

There were the following issues with your Pull Request

  • Commit: 5db9cce
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, build, ci

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

'rxjs/*': './node_modules/rxjs/*',
},
packages: {
'@angular/core': { main: 'index.js', defaultExtension: 'js' },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carl09 can we add common here too?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and compiler

@sebholstein
Copy link
Owner

@carl09 Thank you for PR. Good job! I added some comments. Can you address these comments today and squash all commits to one? Thanks man!

@sebholstein
Copy link
Owner

@carl09 I have made the changes and merged it. Thanks for your time!

@carl09
Copy link
Contributor Author

carl09 commented May 12, 2016

@SebastianM Thanks for the review i am new to gulp, karma and angular2. it was fun to have a go though.

I just had a look at what you fixed up, looks really good, just woke up..

Thanks for creating this project it will be really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants