You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the latest release, there are some missing files. In particular, the pre-compiled tensorflow protobuffs introduced in #942 are not included. This breaks some import paths when tensorflow is not present.
We need to add the missing files to the MANIFEST.in file, so that they get included in the sdist release. To avoid this happening again in the future, we can introduce tox, which will wrap our tests and then run them in a fresh new environment each time (created from the setup.py manifest).
The text was updated successfully, but these errors were encountered:
What's failing?
On the latest release, there are some missing files. In particular, the pre-compiled
tensorflow
protobuffs introduced in #942 are not included. This breaks some import paths whentensorflow
is not present.For instance,
Suggested fix
We need to add the missing files to the
MANIFEST.in
file, so that they get included in thesdist
release. To avoid this happening again in the future, we can introducetox
, which will wrap our tests and then run them in a fresh new environment each time (created from thesetup.py
manifest).The text was updated successfully, but these errors were encountered: