Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Maven and JDK on CI image #1094

Closed
adriangonz opened this issue Nov 11, 2019 · 3 comments
Closed

Upgrade Maven and JDK on CI image #1094

adriangonz opened this issue Nov 11, 2019 · 3 comments
Assignees
@gsunner @ryandawsonuk
Milestone
1.0

Comments

@adriangonz
Copy link
Contributor

adriangonz commented Nov 11, 2019 •
edited
Loading

Our CI image seldonio/core-builder:0.4 currently uses version v3.3.9 of Maven, which is dated from 2015. Likewise, the base openjdk:8u141-jdk Docker image we are using is also 2 years old. It would be good to update both so that it matches local development environments.
@adriangonz adriangonz added this to the 1.0 milestone Nov 11, 2019
@adriangonz adriangonz mentioned this issue Nov 11, 2019
Closed
@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Dec 9, 2019 •
edited
Loading

For the PR builds it now seems to be on seldonio/core-builder:0.6. That doesn't seem to have been updated in all parts of the builds though.

The maven version seems to be coming through indirectly through the base image version. If I switch it to apt-get install -y maven=3.6.2 then I get Version '3.6.2' for 'maven' was not found

@ryandawsonuk
Copy link
Contributor

It seems 3.3.9 is the latest available for that debian distro. May be able to override it though.

@ryandawsonuk ryandawsonuk mentioned this issue Dec 9, 2019
Closed
@ryandawsonuk ryandawsonuk self-assigned this Dec 9, 2019
@gsunner
Copy link
Contributor

gsunner commented Dec 10, 2019 •
edited
Loading

Added PR #1231 to address the core builder changes
The new versions will be
openjdk version "13.0.1" 2019-10-15
Apache Maven 3.6.3

@gsunner gsunner closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsunner gsunner

@ryandawsonuk ryandawsonuk

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

update maven in core builder ryandawsonuk/seldon-core
3 participants
@adriangonz @gsunner @ryandawsonuk