Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to add ambassador circuit-breaker in seldon deployment #1556

Closed
anggao opened this issue Mar 18, 2020 · 4 comments · Fixed by #1661
Closed

Add support to add ambassador circuit-breaker in seldon deployment #1556

anggao opened this issue Mar 18, 2020 · 4 comments · Fixed by #1661
Labels
priority/p2
Milestone
1.2

Comments

@anggao
Copy link
Contributor

anggao commented Mar 18, 2020

Right now seldon-sore doesn't support ambassador circuit-breaker in the deployment. would be great to allow users to configure circuit-breaker for their model deployments.
@anggao anggao added the triage Needs to be triaged and prioritised accordingly label Mar 18, 2020
@anggao
Copy link
Contributor Author

anggao commented Mar 18, 2020

Right now we can provide a custom ambassador config to workaround this issue:

https://github.com/SeldonIO/seldon-core/blob/master/operator/controllers/ambassador.go#L251

Seldon will use it directly, would be great to make seldon merge custom ambassador config provided by users with the one generated by seldon.

@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Mar 19, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Mar 19, 2020
@anggao
Copy link
Contributor Author

anggao commented Apr 3, 2020

@cliveseldon if no one take this I can grab it and try to fix it

@ukclivecox
Copy link
Contributor

That would be great @anggao

@anggao
Copy link
Contributor Author

anggao commented Apr 3, 2020

The plan is to add these new annotations for ambassador

ANNOTATION_AMBASSADOR_CIRCUIT_BREAKING_MAX_CONNECTIONS      = "seldon.io/ambassador-circuit-breakers-max-connections"
ANNOTATION_AMBASSADOR_CIRCUIT_BREAKING_MAX_PENDING_REQUESTS = "seldon.io/ambassador-circuit-breakers-max-pending-requests"
ANNOTATION_AMBASSADOR_CIRCUIT_BREAKING_MAX_REQUESTS         = "seldon.io/ambassador-circuit-breakers-max-requests"
ANNOTATION_AMBASSADOR_CIRCUIT_BREAKING_MAX_RETRIES          = "seldon.io/ambassador-circuit-breakers-max-retries"

@anggao anggao mentioned this issue Apr 3, 2020
Merged
@ukclivecox ukclivecox modified the milestones: 1.2, 1.1.1 Apr 23, 2020
@ukclivecox ukclivecox modified the milestones: 1.1.1, 1.2 Apr 23, 2020
@nadinet nadinet mentioned this issue Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/p2
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add support to add ambassador circuit-breaker in seldon deployment anggao/seldon-core
2 participants
@anggao @ukclivecox