[BUG] NodeSelector not working in SeldonDeployment

[WaterKnight1998]

Describe the bug

I am applying a Deployment that uses NodeSelector to select in which node run the model: gpu or cpu ones.

The yaml looks as follows:

apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: deploy-1
  namespace: seldon
  labels:
spec:
  name: deploy-1
  protocol: seldon
  transport: rest
  annotations:
  predictors:
    - name: "default"
      graph:
        name: "model"
        implementation: MLFLOW_SERVER
        serviceAccountName: ****
        modelUri: gs://****
        type: "MODEL"
      componentSpecs:
      - spec:
        containers:
          - name: "model"
            image:
            imagePullPolicy:
            env:
              name: "LOG_LEVEL"
              value: "INFO"
            resources:
              requests:
                memory: 1Mi
        nodeSelector:
          cloud.google.com/gke-nodepool: gpu-node-pool
      replicas: 1

Expected behaviour

The deployment should use NodeSelector. However, it is getting removed!

Environment

[ukclivecox]

I ran the following against 1.5.0-dev and it worked after labelling one of the nodes to seldon=true

apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: seldon-model
spec:
  name: test-deployment
  predictors:
  - componentSpecs:
    - spec:
        containers:
        - image: seldonio/mock_classifier_rest:1.3
          name: classifier
        nodeSelector:
          seldon: "true"
    graph:
      children: []
      endpoint:
        type: REST
      name: classifier
      type: MODEL
    name: example
    replicas: 1

[WaterKnight1998]

I ran the following against 1.5.0-dev and it worked after labelling one of the nodes to seldon=true

apiVersion: machinelearning.seldon.io/v1
kind: SeldonDeployment
metadata:
  name: seldon-model
spec:
  name: test-deployment
  predictors:
  - componentSpecs:
    - spec:
        containers:
        - image: seldonio/mock_classifier_rest:1.3
          name: classifier
        nodeSelector:
          seldon: "true"
    graph:
      children: []
      endpoint:
        type: REST
      name: classifier
      type: MODEL
    name: example
    replicas: 1

Your example is working! What is wrong with my spec?

[ukclivecox]

- componentSpecs: is a list. Bad yaml?