Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"view source" links in documentation incorrect for JS bindings #7558

Closed
camilstaps opened this issue Sep 12, 2019 · 3 comments
Closed

"view source" links in documentation incorrect for JS bindings #7558

camilstaps opened this issue Sep 12, 2019 · 3 comments
Labels

Comments

@camilstaps
Copy link

camilstaps commented Sep 12, 2019

🐛 Bug Report

The links to the source code from the JS API documentation seem to be incorrect. They point to the right repository, but the files and lines they reference are often incorrect.

Thanks for looking into this!

To Reproduce

Go to https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/index_exports_By.html (e.g.) and click on "view source". The linked line is not related to By.

Expected behavior

In this particular example I'd expect a link like

or
constructor(using, value) {

Test script or set of commands reproducing this issue

Not applicable.

Environment

OS: any
Browser: any
Browser version: any
Browser Driver version: not applicable
Language Bindings version: JS any
Selenium Grid version (if applicable): not applicable

@renjujv
Copy link

renjujv commented Apr 26, 2020

The new documentation URL is:
https://www.selenium.dev/selenium/docs/api/javascript/module/selenium-webdriver/index_exports_By.html

And the correct link to point to by the View Source button seems to be:
https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/lib/by.js

Anyone interested in making the change commit?

@camilstaps
Copy link
Author

Closing because I don't use this anymore and I'm cleaning up my GitHub issues. If you want to keep this tracked, please open a new issue.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants