Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The setup.sh failure due to old Rust version #12

Open
1 task
dloranc opened this issue Sep 14, 2023 · 1 comment
Open
1 task

The setup.sh failure due to old Rust version #12

dloranc opened this issue Sep 14, 2023 · 1 comment

Comments

@dloranc
Copy link
Contributor

dloranc commented Sep 14, 2023

Short overview

I already had Rust installed and during the setup.sh I ran into this issue:

error: failed to compile `git-delta v0.16.5`, intermediate artifacts can be found at `/var/folders/lf/wjmc8r813kq94h9xq5c8dyb00000gn/T/cargo-installOqGSai`

Caused by:
  package `anstream v0.5.0` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.65.0
  Try re-running cargo install with `--locked`
error: failed to compile `bat v0.23.0`, intermediate artifacts can be found at `/var/folders/lf/wjmc8r813kq94h9xq5c8dyb00000gn/T/cargo-installvgbSkO`

Caused by:
  package `clap v4.4.3` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.65.0
  Try re-running cargo install with `--locked`
     Summary Successfully installed exa, hwatch! Failed to install git-delta, bat (see error(s) above).
error: some crates failed to install

The script should check the Rust version is 1.70 or newer.

ToDo

  • check the Rust version in setup.sh
@qbart
Copy link
Member

qbart commented Sep 14, 2023

I think this is rare case, most people don't have rust.

I think comparing versions in shell adds a bit complexity.
Do you think we could reduce the check to "if rust exists" rather than cargo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants