Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: please add 'css' Less 'Import Option' to font imports #55

Open
lfurzewaddock opened this issue Nov 14, 2018 · 5 comments · May be fixed by #58
Open

Request: please add 'css' Less 'Import Option' to font imports #55

lfurzewaddock opened this issue Nov 14, 2018 · 5 comments · May be fixed by #58

Comments

@lfurzewaddock
Copy link

Webpack 4 builds failed which included Semantic-UI less files that featured a web font:

Can't resolve './https://fonts.googleapis.com/css?family=Roboto' in '/MY_PROJECT_DIR/node_modules/semantic-ui-less/themes/material/elements'

The following comment on another repo answered my problem; Import url tries to resolve directory #67

To assist Webpack to load Semantic-UI less files, which include web fonts downloaded from a CDN such as Google, please add Less Import Option css.

For example; themes/material/elements/button.overrides would change from;

@import url(https://fonts.googleapis.com/css?family=Roboto);

.ui.primary.button:hover {
  box-shadow:
    0px 0px 0px 1px rgba(0, 0, 0, 0.3) inset,
    0px 2px 3px 0px rgba(0, 0, 0, 0.35) !important
  ;
}

.ui.secondary.button:hover {
  box-shadow:
    0px 0px 0px 1px rgba(0, 0, 0, 0.2) inset,
    0px 2px 3px 0px rgba(0, 0, 0, 0.3) !important
  ;
}

to;

@import (css) url(https://fonts.googleapis.com/css?family=Roboto);

.ui.primary.button:hover {
  box-shadow:
    0px 0px 0px 1px rgba(0, 0, 0, 0.3) inset,
    0px 2px 3px 0px rgba(0, 0, 0, 0.35) !important
  ;
}

.ui.secondary.button:hover {
  box-shadow:
    0px 0px 0px 1px rgba(0, 0, 0, 0.2) inset,
    0px 2px 3px 0px rgba(0, 0, 0, 0.3) !important
  ;
}
@thefallentree
Copy link

+1

1 similar comment
@terrancesnyder
Copy link

+1

@terrancesnyder terrancesnyder linked a pull request Jan 5, 2019 that will close this issue
Open
@AGontcharov
Copy link

+1

@gentb
Copy link

gentb commented May 2, 2020

Looks like this was resolved in PR: #58

Could we have this merged?

@lubber-de

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

https://github.com/Semantic-Org/Semantic-UI-LESS/issues/55
6 participants
@terrancesnyder @thefallentree @lfurzewaddock @gentb @AGontcharov @lubber-de