Single step border radius fix #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the clear test case and fixed. Added, but removed nested less rules (we don't use those internally). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with the single step element where the border radius style is adhering to a "last child" case. You can see the bug here: http://jsfiddle.net/o7wn9xjd/. I am able to replicate in IE10, IE11, Chrome, Safari and Firefox (I did not test the mobile browsers).
The solution addresses the concept of "the latter rule wins". In this case, the rule for
:last-childholds true during any:only-childcase. This was overriding the:only-childstyle.