From 20361f20d1c5d9bc21433b48f03817b5261751f7 Mon Sep 17 00:00:00 2001 From: Jack Date: Fri, 23 Feb 2018 15:27:46 -0800 Subject: [PATCH 1/8] Add issue templates --- .github/ISSUE_TEMPLATE.md | 26 ++++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 28 ++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 0000000000..6467ee8bb5 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,26 @@ +✖ USAGE QUESTIONS → Use these dedicated resources: + Docs - http://www.semantic-ui.com + Chat - https://gitter.im/Semantic-Org/Semantic-UI + SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes + + +✔ BUGS → This form is required: +✔ Enhancements → Only specific enhancements with detailed descriptions. + +### Issue Titles +Use the format: [Component] Component Should Do X + +For example: [Checkbox] onChange Should Fire when update triggered via DOM + +### Steps + +### Expected Result + +### Actual Result + +### Version +x.y.z + +### Testcase +[Fork, update, and replace to show the bug]: +https://jsfiddle.net/ca0rovs3/ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..53af7dc0ac --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,28 @@ +✖ Multiple features in one PR +✖ New Components Unless Previously Discussed with Maintainers (Consider creating separate repo, I'll link out to you) + +✔ Add comments to complex/confusing code in "code" view of PR +✔ BUGS → This form is required: +✔ Enhancements → Only specific enhancements with detailed descriptions. + +### Issue Titles + +Use the format: [Component] Adds Support for Thing + +For example: [Build Tools] Adds Source Map Support +Or: [Button] Fixes Inheritance for Red Basic Active State + +### Closed Issues +#222 #333 #444 + +### Description + +### Testcase + +[Show before with this fiddle] +https://jsfiddle.net/ca0rovs3/ + +[Consider showing "fixed" case with your fiddle]() + +You can link to your JS using https://rawgit.com/ + From 25b7b268b1cf8b3da4fd2bea999893aceeed12bc Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Fri, 23 Feb 2018 18:43:51 -0500 Subject: [PATCH 2/8] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 6467ee8bb5..97ec739839 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -7,10 +7,9 @@ ✔ BUGS → This form is required: ✔ Enhancements → Only specific enhancements with detailed descriptions. -### Issue Titles +### Title (Put in field above) Use the format: [Component] Component Should Do X - -For example: [Checkbox] onChange Should Fire when update triggered via DOM +i.e. [Checkbox] onChange Should Fire When Update Triggered via DOM ### Steps From 9d23bed313d8b59db41c6a274f1748fce06ca38c Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Fri, 23 Feb 2018 18:44:03 -0500 Subject: [PATCH 3/8] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 97ec739839..8683d0e9cf 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -3,7 +3,6 @@ Chat - https://gitter.im/Semantic-Org/Semantic-UI SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes - ✔ BUGS → This form is required: ✔ Enhancements → Only specific enhancements with detailed descriptions. From b98777755fba6b2bdca5afb58e1b88c7cbf0c713 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Fri, 23 Feb 2018 18:45:36 -0500 Subject: [PATCH 4/8] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 8683d0e9cf..bb9d54c04e 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -4,7 +4,7 @@ SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes ✔ BUGS → This form is required: -✔ Enhancements → Only specific enhancements with detailed descriptions. +✔ Enhancements → Be specific. Assume backwards compatibility is a necessity. Suggest implementation when possible. ### Title (Put in field above) Use the format: [Component] Component Should Do X From 411989c882ee51d17e7bd3efdd631c293a697828 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Fri, 23 Feb 2018 18:46:46 -0500 Subject: [PATCH 5/8] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index bb9d54c04e..4448bc18bf 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -3,8 +3,8 @@ Chat - https://gitter.im/Semantic-Org/Semantic-UI SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes -✔ BUGS → This form is required: ✔ Enhancements → Be specific. Assume backwards compatibility is a necessity. Suggest implementation when possible. +✔ BUGS → <3 <3 <3. Keep in mind some bugs may not be immediately fixable due to backwards compatability or css limitations. ### Title (Put in field above) Use the format: [Component] Component Should Do X From 10ebc9815ab1b470182e7a1cf19dcaef6d3bec58 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Fri, 23 Feb 2018 18:47:17 -0500 Subject: [PATCH 6/8] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 4448bc18bf..4599e1e27a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -4,7 +4,7 @@ SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes ✔ Enhancements → Be specific. Assume backwards compatibility is a necessity. Suggest implementation when possible. -✔ BUGS → <3 <3 <3. Keep in mind some bugs may not be immediately fixable due to backwards compatability or css limitations. +✔ BUGS → ❤❤❤. Keep in mind some bugs may not be immediately fixable due to backwards compatability or css limitations. ### Title (Put in field above) Use the format: [Component] Component Should Do X From 68197433d883a506472ab836788851bef0924788 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Fri, 23 Feb 2018 18:48:00 -0500 Subject: [PATCH 7/8] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 4599e1e27a..a09507814c 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -4,7 +4,7 @@ SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes ✔ Enhancements → Be specific. Assume backwards compatibility is a necessity. Suggest implementation when possible. -✔ BUGS → ❤❤❤. Keep in mind some bugs may not be immediately fixable due to backwards compatability or css limitations. +✔ BUGS → ❤❤❤. Keep in mind some bugs may not be immediately fixable due to backwards compatibility or CSS limitations. ### Title (Put in field above) Use the format: [Component] Component Should Do X From 64b9fdb46ea66cf3cd9e9b3bce9fefc891910f49 Mon Sep 17 00:00:00 2001 From: Sean Hamilton Date: Mon, 5 Mar 2018 13:39:17 +0000 Subject: [PATCH 8/8] Added primary & secondary inverted buttons Fixes #5643 --- src/definitions/elements/button.less | 54 ++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/src/definitions/elements/button.less b/src/definitions/elements/button.less index fbb5fe12ae..8c856f0539 100755 --- a/src/definitions/elements/button.less +++ b/src/definitions/elements/button.less @@ -329,12 +329,22 @@ Inverted --------------------*/ -.ui.inverted.button { +.ui.inverted.button:not(.primary + .secondary) { box-shadow: 0px 0px 0px @invertedBorderSize @white inset !important; background: transparent none; color: @white; text-shadow: none !important; } +.ui.inverted.primary.button { + box-shadow: 0px 0px 0px @invertedBorderSize @primaryColor inset !important; + background: transparent none; + color: @primaryColor; +} +.ui.inverted.secondary.button { + box-shadow: 0px 0px 0px @invertedBorderSize @secondaryColor inset !important; + background: transparent none; + color: @secondaryColor; +} /* Group */ .ui.inverted.buttons .button { @@ -353,25 +363,57 @@ /* States */ /* Hover */ -.ui.inverted.button:hover { +.ui.inverted.button:hover:not(.primary + .secondary) { background: @white; box-shadow: 0px 0px 0px @invertedBorderSize @white inset !important; color: @hoverColor; } +.ui.inverted.primary.button:hover { + background: @primaryColorHover; + box-shadow: 0px 0px 0px @invertedBorderSize @primaryColorHover inset !important; + color: @white; +} +.ui.inverted.secondary.button:hover { + background: @secondaryColorHover; + box-shadow: 0px 0px 0px @invertedBorderSize @secondaryColorHover inset !important; + color: @white; +} /* Active / Focus */ -.ui.inverted.button:focus, -.ui.inverted.button.active { +.ui.inverted.button:focus:not(.primary + .secondary), +.ui.inverted.button.active:not(.primary + .secondary) { background: @white; box-shadow: 0px 0px 0px @invertedBorderSize @white inset !important; color: @focusColor; } +.ui.inverted.primary.button:focus, +.ui.inverted.primary.button.active { + background: @primaryColorActive; + box-shadow: 0px 0px 0px @invertedBorderSize @primaryColorActive inset !important; + color: @white; +} +.ui.inverted.secondary.button:focus, +.ui.inverted.secondary.button.active { + background: @secondaryColorActive; + box-shadow: 0px 0px 0px @invertedBorderSize @secondaryColorActive inset !important; + color: @white; +} /* Active Focus */ -.ui.inverted.button.active:focus { +.ui.inverted.button.active:focus:not(.primary + .secondary) { background: @midWhite; box-shadow: 0px 0px 0px @invertedBorderSize @midWhite inset !important; - color: @focusColor; + color: @white; +} +.ui.inverted.primary.button.active:focus { + background: @primaryColorActive; + box-shadow: 0px 0px 0px @invertedBorderSize @primaryColorActive inset !important; + color: @white; +} +.ui.inverted.secondary.button.active:focus { + background: @secondaryColorActive; + box-shadow: 0px 0px 0px @invertedBorderSize @secondaryColorActive inset !important; + color: @white; }