Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try removing eslint as dependency #258

Closed
Seqi opened this issue Feb 27, 2021 · 2 comments
Closed

Try removing eslint as dependency #258

Seqi opened this issue Feb 27, 2021 · 2 comments
Labels
easy Small amount of effort

Comments

@Seqi
Copy link
Owner

Seqi commented Feb 27, 2021

eslint is part of create-react-app yet its installed in package.json too. Likely not needed but i forget why its there. Ideally we'd like to remove it as it can cause problems when theyg et out of sync.
@Seqi Seqi added the easy Small amount of effort label Feb 27, 2021
@Seqi
Copy link
Owner Author

Seqi commented Feb 27, 2021

Can also look at eslint rules here for testingjest: facebook/create-react-app#8978

@Seqi
Copy link
Owner Author

Seqi commented Feb 28, 2021

Done in commit aeb7c7a898ce3c8e0cd6da9e32cc55a22e1a8232

@Seqi Seqi closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Small amount of effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Seqi