Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexed keyword between BasicIssuanceModule and CustomOracleNavIssuanceModule are different #239

Open
gzliudan opened this issue Mar 29, 2022 · 0 comments · May be fixed by #261
Open

indexed keyword between BasicIssuanceModule and CustomOracleNavIssuanceModule are different #239

gzliudan opened this issue Mar 29, 2022 · 0 comments · May be fixed by #261

Comments

@gzliudan
Copy link
Contributor

gzliudan commented Mar 29, 2022

events have indexed keyword in BasicIssuanceModule before _issuer and _to parameter:

    event SetTokenIssued(
        address indexed _setToken,
        address indexed _issuer,
        address indexed _to,
        address _hookContract,
        uint256 _quantity
    );
    event SetTokenRedeemed(
        address indexed _setToken,
        address indexed _redeemer,
        address indexed _to,
        uint256 _quantity
    );

events have no indexed keyword in CustomOracleNavIssuanceModule and NavIssuanceModule before _issuer and _to parameter:

    event SetTokenNAVIssued(
        ISetToken indexed _setToken,
        address _issuer,
        address _to,
        address _reserveAsset,
        address _hookContract,
        uint256 _setTokenQuantity,
        uint256 _managerFee,
        uint256 _premium
    );

    event SetTokenNAVRedeemed(
        ISetToken indexed _setToken,
        address _redeemer,
        address _to,
        address _reserveAsset,
        address _hookContract,
        uint256 _setTokenQuantity,
        uint256 _managerFee,
        uint256 _premium
    );
@matt-user matt-user linked a pull request Aug 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant