Disable extension splitting on Windows for os_sorted #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that this is not a behavior that Windows supports - it adds e.g. (2) after the extension, not before, so it does not account for extensions when sorting.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 10 10
Lines 606 607 +1
=======================================
+ Hits 597 598 +1
Misses 9 9
☔ View full report in Codecov by Sentry. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 28, 2023
[8.4.0] - 2023-06-19 --- ### Changed - The changelog now only explictly exists in the repository (issue [#162](SethMMorton/natsort#162)) ### Fixed - Inputs with spaces near adjascent to the extension are now sorted correctly for `os_sorted` on Windows (issues [#165](SethMMorton/natsort#165) and [#166](SethMMorton/natsort#166))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that this is not a behavior that Windows supports - it adds e.g. (2) after the extension, not before, so it does not account for extensions when sorting.