Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the hard-coded unicode hex table for Python 3.13 #175

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Update the hard-coded unicode hex table for Python 3.13 #175

merged 1 commit into from
Jun 9, 2024

Conversation

robert-scheck
Copy link
Contributor

When building natsort 8.4.0 on Fedora Rawhide against Python 3.13 branch (build.log):

+ /usr/bin/pytest
============================= test session starts ==============================
platform linux -- Python 3.13.0b2, pytest-7.4.3, pluggy-1.3.0
rootdir: /builddir/build/BUILD/python-natsort-8.4.0-build/natsort-8.4.0
plugins: mock-3.12.0, hypothesis-6.98.8
collected 333 items
tests/test_fake_fastnumbers.py ...............                           [  4%]
tests/test_final_data_transform_factory.py ........                      [  6%]
tests/test_input_string_transform_factory.py ..........sssssss           [ 12%]
tests/test_main.py ......................                                [ 18%]
tests/test_natsort_key.py .....                                          [ 20%]
tests/test_natsort_keygen.py .....................                       [ 26%]
tests/test_natsorted.py ....................................sss......... [ 40%]
...                                                                      [ 41%]
tests/test_natsorted_convenience.py .............                        [ 45%]
tests/test_ns_enum.py .......................................            [ 57%]
tests/test_os_sorted.py .....                                            [ 58%]
tests/test_parse_bytes_function.py ....                                  [ 60%]
tests/test_parse_number_function.py ...........                          [ 63%]
tests/test_parse_string_function.py ....                                 [ 64%]
tests/test_regex.py .................................................... [ 80%]
                                                                         [ 80%]
tests/test_string_component_transform_factory.py .........               [ 82%]
tests/test_unicode_numbers.py ......                                     [ 84%]
tests/test_utils.py ...................................................  [100%]
=============================== warnings summary ===============================
tests/test_unicode_numbers.py::test_missing_unicode_number_in_collection
  /usr/lib/python3.13/site-packages/_pytest/python.py:194: UserWarning: Not all numeric unicode characters are represented in natsort/unicode_numeric_hex.py
  This can be addressed by running dev/generate_new_unicode_numbers.py with the current version of Python.
  It would be much appreciated if you would submit a Pull Request to the natsort
  repository (https://github.com/SethMMorton/natsort) with the resulting change.
  
    result = testfunction(**testargs)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================= 323 passed, 10 skipped, 1 warning in 19.83s ==================
+ RPM_EC=0

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (e37113b) to head (cff0e1e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          10       10           
  Lines         601      601           
=======================================
  Hits          598      598           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SethMMorton SethMMorton merged commit 974750d into SethMMorton:main Jun 9, 2024
15 of 16 checks passed
@robert-scheck robert-scheck deleted the python-3.13 branch June 9, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants