Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slow!! #16

Open
0x000777 opened this issue Nov 16, 2018 · 2 comments · May be fixed by #17
Open

Very slow!! #16

0x000777 opened this issue Nov 16, 2018 · 2 comments · May be fixed by #17

Comments

@0x000777
Copy link

Very slow compared to PHP implementation - https://github.com/serbanghita/Mobile-Detect/blob/master/Mobile_Detect.php

@dimiro1
Copy link

dimiro1 commented Nov 16, 2018

@Highter87 Could you share the benchmark you used to compare both implementations?

@Shaked
Copy link
Owner

Shaked commented Nov 17, 2018

I haven't updated this library for long time. You guys are more than welcome to improve with a pull request 🙂

@guessi guessi linked a pull request Mar 30, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants