Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advance the SettingConfiger #94

Open
4 tasks
Sharlottes opened this issue Aug 28, 2023 · 0 comments
Open
4 tasks

advance the SettingConfiger #94

Sharlottes opened this issue Aug 28, 2023 · 0 comments
Assignees
Labels
enhancement inprovment exiting features refactor clean up code, fix ambiguous things
Milestone

Comments

@Sharlottes
Copy link
Owner

image

SettingConfiger will...

  • have EventEmitter, for detecting setting changes without any cost, or any dependents.
  • store various of types. not only boolean but also float, int... which Core.setting can store.
  • Because of the above feature, the consumers who want to configure will resolve their own UI. but that's DRY, so SettingConfiger's subclass will describe which is shown to control the config value.
  • The current way to access the SettingConfiger is across classes like ToolManager or OverDrawManager. because SettingConfiger should act like Core.setting but more fast and cheaper, this should be singleton.

These changes will...

  • Clean up Setting and ToolWindow codes.
  • You can use or listen to setting configuring anywhere, anytime through a pre-supplied UI or interface.
@Sharlottes Sharlottes added enhancement inprovment exiting features refactor clean up code, fix ambiguous things labels Aug 28, 2023
@Sharlottes Sharlottes added this to the v1.10 Roadmap milestone Aug 28, 2023
@Sharlottes Sharlottes self-assigned this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement inprovment exiting features refactor clean up code, fix ambiguous things
Projects
None yet
Development

No branches or pull requests

1 participant