Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce Core.setting.get call number of times #95

Open
Sharlottes opened this issue Aug 28, 2023 · 0 comments
Open

reduce Core.setting.get call number of times #95

Sharlottes opened this issue Aug 28, 2023 · 0 comments
Assignees
@Sharlottes
Labels
refactor clean up code, fix ambiguous things
Milestone
v1.10 Roadmap

Comments

@Sharlottes
Copy link
Owner

Core.setting.get is the suspect of lagging. (When I did not use this, dropping 5 frames will restore to 120 frames)
so every Core.setting.get should be cached or replaced with SettingConfiger.
@Sharlottes Sharlottes self-assigned this Aug 28, 2023
@Sharlottes Sharlottes added the refactor clean up code, fix ambiguous things label Aug 28, 2023
@Sharlottes Sharlottes mentioned this issue Aug 28, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sharlottes Sharlottes

Labels
refactor clean up code, fix ambiguous things
Projects
None yet
Milestone
v1.10 Roadmap
Development

No branches or pull requests
1 participant
@Sharlottes