Adds the ability to integrate with collection/table view prefetch #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulriera
approved these changes
Apr 18, 2019
| } | ||
|
|
||
| private extension NSLocking { | ||
| func withLock<T> (_ body: () throws -> T) rethrows -> T { |
There was a problem hiding this comment.
I was wondering about this withLock. I t thought it was a new thing in iOS
|
|
||
| private func section(withPrefetch prefetchAction: @escaping CellActions.PrefetchAction) -> TableSection { | ||
| let actions = CellActions(prefetchAction: prefetchAction) | ||
| let cell = HostCell<UIView, String, LayoutMarginsTableItemLayout>(key: "prefetch-cell", actions: actions, state: "Actions") { (_, _) in } |
There was a problem hiding this comment.
Pretty sure we have some TestCell or something out there
g-Off
force-pushed
the
prefetch
branch
3 times, most recently
from
af25163
to
6f55f4e
Compare
ghost
added
the
Prefetch operations are requested from CellActions and executed in a private OperationQueue. The actual fetching/cancelling is delayed by a short period of time because iOS may trigger rapid fetch/cancel operations and this is an attempt to reduce the amount of fetch/cancel/fetch of the same IndexPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefetch operations are requested from CellActions and executed in a private OperationQueue. The actual fetching/cancelling is delayed by a short period of time because iOS may trigger rapid fetch/cancel operations and this is an attempt to reduce the amount of fetch/cancel/fetch of the same IndexPath
This PR introduces a common prefetch data source that's usable by both collection and tableview's. They essentially have the same delegate methods, just passing in a UICollectionView in one and a UITableView in the other. Object conforms to both, takes advantage of the same mechanism for queueing and dequeuing operations/cancelling/etc.
This resolves #152