Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIContextualAction won't render both image and text if cell is <= 90pts #158

Open
g-Off opened this issue Apr 11, 2019 · 2 comments
Open
Milestone

Comments

@g-Off
Copy link
Contributor

g-Off commented Apr 11, 2019

http://www.openradar.me/33107135

In FunctionalTableData, when the contextual actions are being created, we can determine if the cell is this height and instead return a pre-rendered (and likely cached) image that includes both the text and the image. This might be a configurable property to allow it to be opted in or out.

This could have some side effects in scenarios where the cell changes size while the action is visible (device rotation, tableview gets wider).

@g-Off g-Off added the Bug label Apr 11, 2019
@runmad
Copy link

runmad commented Apr 23, 2019

This could have some side effects in scenarios where the cell changes size while the action is visible (device rotation, tableview gets wider).

What I've done in the past is simple set editing for the cell to false in those scenarios, which returns the cell back to the normal state without the contextual actions visible. I would argue that this solution is satisfactory in most cases; likelihood of the cell changing height without a rotation is small for most use cases.

Likewise, check an app like Messages.app. Swipe to reveal actions and then rotate your device to landscape or vice versa 💩

@ghost
Copy link

ghost commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 3 days if no further activity occurs.

@ghost ghost added the Stale label May 14, 2019
@ghost ghost closed this as completed May 17, 2019
@g-Off g-Off reopened this May 17, 2019
@g-Off g-Off added Pinned and removed Stale labels May 17, 2019
@g-Off g-Off added this to the v2 milestone May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants