Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs after branch rename master -> main #214

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Update docs after branch rename master -> main #214

merged 3 commits into from
Apr 9, 2024

Conversation

Caiopia
Copy link
Member

@Caiopia Caiopia commented Apr 8, 2024 •
edited
Loading

This just updates the file paths after renaming master to main. It's probably worth checking if those links still go to the right spots.

@Caiopia
Copy link
Member Author

Caiopia commented Apr 8, 2024

You can test the file paths by checking the branch out and opening the docs locally at file://<path to FunctionalTableData>/docs/index.html. Next, navigate to a function or type that offers the option to "View on GitHub" and verify it doesn't 404 anymore compared with the hosted docs https://shopify.github.io/FunctionalTableData/.

dannbeau
dannbeau approved these changes Apr 9, 2024
View reviewed changes
Copy link

@dannbeau dannbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 ✔️

@Caiopia Caiopia merged commit b4f7c99 into main Apr 9, 2024
2 checks passed
@Caiopia Caiopia deleted the update-docs branch April 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannbeau dannbeau dannbeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caiopia @dannbeau