Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structured_data filter throws Liquid error when first media isn't an image #3600

Open
bertiful opened this issue Sep 3, 2024 · 1 comment

Comments

@bertiful
Copy link
Contributor

bertiful commented Sep 3, 2024

The structured_data filter throws a Liquid error: invalid url input error when a product has the following conditions:

  1. A single variant
  2. The first media isn't an image, i.e. a video or 3D model

Usage:

<script type="application/ld+json">
  {{ product | structured_data }}
</script>

There may be other product setup conditions that affect this. This happens in Dawn as well.

cc @ludoboludo @tyleralsbury (👋🏻)

@tyleralsbury
Copy link
Contributor

Thanks for this, @bertiful . I'll bring it to the team and we'll see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants