From 478c1f0ad0df8f29a42b582db8af84359099bbea Mon Sep 17 00:00:00 2001 From: Jenny Shen Date: Tue, 2 Apr 2024 19:16:42 -0400 Subject: [PATCH 1/3] Set .ruby-version to 2.7.8 dev.yml reads from .ruby-version --- .ruby-version | 1 + dev.yml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .ruby-version diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 0000000..a04abec --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +2.6.10 diff --git a/dev.yml b/dev.yml index 9e38a60..a5b3339 100644 --- a/dev.yml +++ b/dev.yml @@ -3,7 +3,7 @@ type: - ruby up: - - ruby: "2.6.10" + - ruby - bundler test: "rake test" From aefc266a6d5926cdf2a9686d6d80efe06ce988e7 Mon Sep 17 00:00:00 2001 From: Jenny Shen Date: Tue, 2 Apr 2024 19:17:31 -0400 Subject: [PATCH 2/3] Remove ruby reference in Gemfile --- Gemfile | 2 -- Gemfile.lock | 3 --- 2 files changed, 5 deletions(-) diff --git a/Gemfile b/Gemfile index ecac571..64e14fd 100644 --- a/Gemfile +++ b/Gemfile @@ -1,8 +1,6 @@ # frozen_string_literal: true source "https://rubygems.org" -ruby ">= 2.6" - # None of these can actually be used in a development copy of dev # They are all for CI and tests # `dev` uses no gems diff --git a/Gemfile.lock b/Gemfile.lock index 674f965..2570d92 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -57,8 +57,5 @@ DEPENDENCIES rubocop-rake rubocop-shopify (~> 2.0.1) -RUBY VERSION - ruby 2.7.2p137 - BUNDLED WITH 2.2.22 From 61c9405e3a982ab7dea090eb9cc0f3e94622ab7a Mon Sep 17 00:00:00 2001 From: Jenny Shen Date: Tue, 2 Apr 2024 19:18:24 -0400 Subject: [PATCH 3/3] Remove ruby version definition in CI/CD it will be read from .ruby-version --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 97fc497..18b51f7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,8 +47,6 @@ jobs: - uses: actions/checkout@v3 - uses: ruby/setup-ruby@v1 - with: - ruby-version: 2.6 - name: Install dependencies run: bundle install