From 3add3bea58061d9ecd5232f0ac7fdac9acfe035b Mon Sep 17 00:00:00 2001
From: Anthony Frehner <frehner@users.noreply.github.com>
Date: Fri, 11 Nov 2022 07:41:54 -0700
Subject: [PATCH] include xstate in builds (#64)

* include xstate in builds

* Fix NextJS issues by including files with sideeffects

See https://github.com/vitejs/vite/issues/10866 for more details
---
 packages/react/package.json   | 7 ++++++-
 packages/react/vite.config.ts | 7 +++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/packages/react/package.json b/packages/react/package.json
index bf7407a1..5c6be30e 100644
--- a/packages/react/package.json
+++ b/packages/react/package.json
@@ -54,7 +54,12 @@
   "types": "./dist/types/index.d.ts",
   "unpkg": "./dist/umd/hydrogen-react.prod.js",
   "jsdelivr": "./dist/umd/hydrogen-react.prod.js",
-  "sideEffects": false,
+  "sideEffects": [
+    "dist/dev/node_modules/use-sync-external-store/shim/with-selector.mjs",
+    "dist/prod/node_modules/use-sync-external-store/shim/with-selector.mjs",
+    "dist/dev/node_modules/use-sync-external-store/shim/with-selector.js",
+    "dist/prod/node_modules/use-sync-external-store/shim/with-selector.js"
+  ],
   "scripts": {
     "clean-dist": "rimraf ./dist",
     "dev": "run-s clean-dist dev:demo",
diff --git a/packages/react/vite.config.ts b/packages/react/vite.config.ts
index f6cb2c86..b23bf814 100644
--- a/packages/react/vite.config.ts
+++ b/packages/react/vite.config.ts
@@ -57,8 +57,7 @@ export default defineConfig(({mode}) => {
       minify: false,
       emptyOutDir: false,
       rollupOptions: {
-        // don't bundle these packages into our lib
-        external: (id, parentId) => {
+        external: (id) => {
           /**
            * Don't bundle these packages into our lib
            *
@@ -66,8 +65,8 @@ export default defineConfig(({mode}) => {
            * but if we wanted a browser esm build, we would either have to tell devs to use "import maps"
            * or to create a new bundle that doesn't use these as externals
            * */
-          if (parentId?.includes('@xstate') || id.includes('@xstate')) {
-            return true;
+          if (id.includes('xstate')) {
+            return false;
           }
 
           return externals.includes(id);