-
Notifications
You must be signed in to change notification settings - Fork 64
Redirect to cookie grant page using App Bridge #148
Conversation
8799a6f
to
e4b471d
Compare
e4b471d
to
a7da8d3
Compare
@henrytao-me we added a local copy of app bridge v2, please give this another look. Thanks!
Upgrading shopify-api to latest version
👋 It looks like you're updating JavaScript packages that are known You can deduplicate them with the
If running these commands doesn't produce a change in your yarn.lock file, A duplicate React version may cause an invalid hook call warning. React context providers usually use module-scoped globals as their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍. Haven't had time to tophat though. Thanks for doing this 🙇
WHY are these changes introduced?
EASDK is deprecated, and we're currently still relying on it for one of the top-level redirects required to handle ITP for Safari. We need to migrate away from doing that.
WHAT is this pull request doing?
Replacing the current EASDK-based call with an App Bridge (v1 for consistency with other usages in this package)
Redirect
action.I verified that the redirect works with App Bridge on Safari.
Type of change