Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Redirect to cookie grant page using App Bridge #148

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

paulomarg
Copy link
Contributor

@paulomarg paulomarg commented Feb 23, 2022

WHY are these changes introduced?

EASDK is deprecated, and we're currently still relying on it for one of the top-level redirects required to handle ITP for Safari. We need to migrate away from doing that.

WHAT is this pull request doing?

Replacing the current EASDK-based call with an App Bridge (v1 for consistency with other usages in this package) Redirect action.

I verified that the redirect works with App Bridge on Safari.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

@paulomarg paulomarg requested a review from a team February 23, 2022 15:47
@paulomarg paulomarg force-pushed the paulo/replace_easdk_with_app_bridge branch from 8799a6f to e4b471d Compare February 23, 2022 15:55
src/auth/create-request-storage-access.ts Outdated Show resolved Hide resolved
src/auth/create-request-storage-access.ts Outdated Show resolved Hide resolved
@paulomarg paulomarg force-pushed the paulo/replace_easdk_with_app_bridge branch from e4b471d to a7da8d3 Compare February 23, 2022 21:02
@JaKXz JaKXz dismissed henrytao-me’s stale review February 23, 2022 21:24

@henrytao-me we added a local copy of app bridge v2, please give this another look. Thanks!

@caution-tape-bot caution-tape-bot bot requested a review from a team February 23, 2022 21:27
@DAmatheson DAmatheson removed the request for review from a team February 23, 2022 21:34
@Shopify Shopify deleted a comment from caution-tape-bot bot Feb 23, 2022
@caution-tape-bot caution-tape-bot bot requested a review from a team February 23, 2022 21:36
@caution-tape-bot
Copy link

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

Copy link
Member

@henrytao-me henrytao-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍. Haven't had time to tophat though. Thanks for doing this 🙇

@paulomarg paulomarg merged commit 32517fa into master Feb 24, 2022
@paulomarg paulomarg deleted the paulo/replace_easdk_with_app_bridge branch February 24, 2022 15:12
@shopify-shipit shopify-shipit bot temporarily deployed to production February 24, 2022 15:26 Inactive
@Shopify Shopify deleted a comment from caution-tape-bot bot Feb 24, 2022
@DAmatheson DAmatheson removed the request for review from a team February 24, 2022 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants